[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)
    Tim Shen via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Dec 20 13:46:02 PST 2016
    
    
  
timshen added a comment.
I changed type style to early return.
For constructors and destructors, I use:
  if (...) {
    // statement;
    return;
  }
For normal functions that returns void, I chose:
  if (...)
    return Foo();
  llvm_unreachable(...);
since it's more compact. If returning void looks weird, we should add it to the style guide.
Other functions are not controversial.
https://reviews.llvm.org/D27872
    
    
More information about the llvm-commits
mailing list