[PATCH] D26878: [GlobalISel] Add tentative Selector-emitted tablegen backend.

[Zvi Rackover via Phabricator via llvm-commits]

zvi added a comment.

Hi Ahmed, thanks for doing this work. I don't have much mileage in GlobalISel, but FWIW, this patch LGTM.



================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:340
+     << "InstructionSelector::selectImpl"
+        "(MachineInstr &I) const {\n  MachineRegisterInfo &MRI = "
+        "I.getParent()->getParent()->getRegInfo();\n";
----------------
Minor: make MRI be a const reference?


================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:344
+  // Look through the SelectionDAG patterns we found, possibly emitting some.
+  for (const PatternToMatch &Pat : CGP.ptms()) {
+    ++NumPatternTotal;
----------------
To the best of my knowledge there is no CodeGenDAGPatterns::ptms().


https://reviews.llvm.org/D26878