[PATCH] D27973: [ELF] - Do not call fatal() in Target.cpp, call error() instead.

[George Rimar via llvm-commits]

>> +## invalid-relocation-x64.elf contains relocation with invalid index
>It is not the index that is the problem here...
Invalid id ?

"invalid-relocation-x64.elf contains relocation with invalid numeric id" ?

Best regards,
George.
________________________________________
От: Rafael Avila de Espindola <rafael.espindola at gmail.com>
Отправлено: 20 декабря 2016 г. 16:43
Кому: reviews+D27973+public+33df21fca84b9ab6 at reviews.llvm.org; George Rimar; ruiu at google.com
Копия: Evgeny Leviant; llvm-commits at lists.llvm.org
Тема: Re: [PATCH] D27973: [ELF] - Do not call fatal() in Target.cpp, call error() instead.

Using error for "unrecognized reloc" probably makes sense. Can you
change the test to have two unrecognized relocations?

> +## invalid-relocation-x64.elf contains relocation with invalid index
It is not the index that is the problem here...

> +# RUN: not ld.lld %p/Inputs/invalid-relocation-x64.elf -o %t2 2>&1 | FileCheck %s
> +# CHECK: unrecognized reloc 153

Cheers,
Rafael