[lld] r290174 - [ELF] - Treat .openbsd.randomdata as relro section

[George Rimar via llvm-commits]

Author: grimar
Date: Tue Dec 20 05:28:54 2016
New Revision: 290174

URL: http://llvm.org/viewvc/llvm-project?rev=290174&view=rev
Log:
[ELF] - Treat .openbsd.randomdata as relro section

That was requested by Mark Kettenis in llvm-dev:

"It is the intention that .openbsd.randomdata sections are made
read-only after initialization. The native (ld.bfd based) OpenBSD
toolchain accomplishes this by including .openbsd.randomdata into the
PT_GNU_RELRO segment."

He suggested code change, I added testcase.

Differential revision: https://reviews.llvm.org/D27974

Modified:
    lld/trunk/ELF/Writer.cpp
    lld/trunk/test/ELF/relro.s

Modified: lld/trunk/ELF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=290174&r1=290173&r2=290174&view=diff
==============================================================================
--- lld/trunk/ELF/Writer.cpp (original)
+++ lld/trunk/ELF/Writer.cpp Tue Dec 20 05:28:54 2016
@@ -500,7 +500,7 @@ template <class ELFT> bool elf::isRelroS
     return true;
   StringRef S = Sec->getName();
   return S == ".data.rel.ro" || S == ".ctors" || S == ".dtors" || S == ".jcr" ||
-         S == ".eh_frame";
+         S == ".eh_frame" || S == ".openbsd.randomdata";
 }
 
 template <class ELFT>

Modified: lld/trunk/test/ELF/relro.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/relro.s?rev=290174&r1=290173&r2=290174&view=diff
==============================================================================
--- lld/trunk/test/ELF/relro.s (original)
+++ lld/trunk/test/ELF/relro.s Tue Dec 20 05:28:54 2016
@@ -19,8 +19,8 @@
 // CHECK-NEXT: GNU_RELRO
 // CHECK: Section to Segment mapping:
 
-// FULLRELRO:  05     .dynamic .got .got.plt {{$}}
-// PARTRELRO:  05     .dynamic .got {{$}}
+// FULLRELRO:  05     .openbsd.randomdata .dynamic .got .got.plt {{$}}
+// PARTRELRO:  05     .openbsd.randomdata .dynamic .got {{$}}
 
 
 // NORELRO-NOT: GNU_RELRO
@@ -36,3 +36,6 @@ _start:
 .zero 4
 .section .foo,"aw"
 .section .bss,"", at nobits
+
+.section .openbsd.randomdata, "aw"
+.quad 0