[PATCH] D27963: [Codegen] Have the generic debug skip functions return true on empty.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 20 03:02:13 PST 2016
fhahn added a comment.
`skipDebugInstructionsForward/Backward` take the iterator by value and return the advanced iterator again, because it seemed more in line with C++'s iterator functions (like next and prev), @MatzeB suggested that in https://reviews.llvm.org/D27782#623009 .
In my opinion, it's obvious what the current implementation does by just looking at the call and having the end/beginning checks are in the caller's code, whereas the version proposed in this review is a little bit less obvious and the savings in code size seem quite small.
Repository:
rL LLVM
https://reviews.llvm.org/D27963
More information about the llvm-commits
mailing list