[PATCH] D27808: [globalisel] Initialize RegisterBanks with static data. Part 2 of 2.

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/RegisterBank.h:36
+    uint64_t CoveredClasses;
   } DataTy;
 
----------------
qcolombet wrote:
> I would directly give access to the field instead of having an intermediate structure.
> Just add a comment that those shouldn't be touched because they are tablegen'ed.
> 
> At the same time, we would eliminate the default constructor and the friend relationship with the RegisterBankInfo.
> Have a look to TargetRegisterClass.
> I would directly give access to the field instead of having an intermediate structure.
> Just add a comment that those shouldn't be touched because they are tablegen'ed.

Let's discuss this on D27807 since the outcome of that determines what we do here.

> At the same time, we would eliminate the default constructor

D27809 does this.

> and the friend relationship with the RegisterBankInfo.

I haven't checked whether this can be done yet. I'll take a look


https://reviews.llvm.org/D27808