[PATCH] D27770: [ELF][MIPS] Allow .MIPS.abiflags larger than one Elf_Mips_ABIFlags struct

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 23:46:48 PST 2016


ruiu added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:137
     std::string Filename = toString(Sec->getFile());
-    if (Sec->Data.size() != sizeof(Elf_Mips_ABIFlags)) {
-      error(Filename + ": invalid size of .MIPS.abiflags section");
+    const auto Size = Sec->Data.size();
+    // Older version of BFD (such as the default FreeBSD linker) concatenate
----------------
Can you please use `size_t` instead of `auto`?


https://reviews.llvm.org/D27770





More information about the llvm-commits mailing list