[PATCH] D27901: [X86][[AVX512] Code size reduction in X86 by replacing EVEX with VEX encoding

[Gadi Haber via Phabricator via llvm-commits]

gadi.haber marked 6 inline comments as done.
gadi.haber added inline comments.


================
Comment at: lib/MC/MCAsmStreamer.cpp:303
 /// verbose assembly output is enabled.
-void MCAsmStreamer::AddComment(const Twine &T) {
+void MCAsmStreamer::AddComment(const Twine &T, bool EOL) {
   if (!IsVerboseAsm) return;
----------------
zvi wrote:
> Have you considered using GetCommentOS() or EmitRawComment() before modifying this method?
Yes, but they did not generate a concatenated comment.


================
Comment at: lib/Target/X86/X86EvexToVex.cpp:130
+
+// For EVEX instructions that can be encoded using VEX encodig, 
+// replace them by the VEX encoding in order to reduce size:
----------------
zvi wrote:
> *encoding
Did you mean removing the comma that follows encoding?


Repository:
  rL LLVM

https://reviews.llvm.org/D27901