[PATCH] D27457: [globalisel] Tablegen-erate PartialMapping*/ValueMapping*/BankIDToCopyMapIdx.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet requested changes to this revision.
qcolombet added a comment.
This revision now requires changes to proceed.

Hi Daniel,

I think I already mentioned that in another review, but I expect the generation of the mappings to be part of some instruction selector tablegen backend. Indeed a mapping is bound to an instruction, not a register bank. The mappings happen to use register banks but are not derived from them, thus I don't think it makes sense to have their generation in the RegisterBankEmitter.

Cheers,
-Quentin



================
Comment at: lib/Target/AArch64/AArch64GenRegisterBankInfo.def:73
          "Mapping out of bound");
+  assert(ValMappings[ValMappingIdx].BreakDown != nullptr && "Hit an invalid copy");
   return &ValMappings[ValMappingIdx];
----------------
Looks like general goodness, commit that part separately.


https://reviews.llvm.org/D27457