[PATCH] D27711: ELF/AArch64: Fix dynamic relocation against local symbol in shared objects

Adhemerval Zanella via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 13:27:36 PST 2016



On 18/12/2016 23:56, Rafael Avila de Espindola wrote:
> Adhemerval Zanella via Phabricator <reviews at reviews.llvm.org> writes:
>> @@ -154,8 +154,8 @@
>>        Config->Shared) {
>>      if (In<ELFT>::Got->addDynTlsEntry(Body)) {
>>        uintX_t Off = In<ELFT>::Got->getGlobalDynOffset(Body);
>> -      In<ELFT>::RelaDyn->addReloc(
>> -          {Target->TlsDescRel, In<ELFT>::Got, Off, false, &Body, 0});
>> +      In<ELFT>::RelaDyn->addReloc({Target->TlsDescRel, In<ELFT>::Got, Off,
>> +                                   !Body.isPreemptible(), &Body, 0});
> 
> Please use the existing variable. LGTM with that.
> 
> Cheers,
> Rafael
> 

Sorry, I missed this comment, I will fix it upstream.


More information about the llvm-commits mailing list