[PATCH] D27885: Make a function to correctly extract the DW_AT_high_pc given the low pc value.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 11:37:59 PST 2016


probinson added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFDie.h:288
   
+  /// Get the DW_AT_high_pc attribute value as an address
+  ///
----------------
Comment should end with a period.


================
Comment at: unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp:796
+template <uint16_t Version, class AddrType> void TestAddresses() {
+  // Test DWARF API that grab the DW_AT_high_pc
+  const uint8_t AddrSize = sizeof(AddrType);
----------------
Comment should end with a period.  Also 'grabs' not 'grab'.


https://reviews.llvm.org/D27885





More information about the llvm-commits mailing list