[PATCH] D27871: [libFuzzer] Remove AFL test on Windows.

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 09:22:07 PST 2016


mpividori abandoned this revision.
mpividori added inline comments.


================
Comment at: lib/Fuzzer/test/no-coverage/CMakeLists.txt:20
 
-add_executable(AFLDriverTest
-  ../AFLDriverTest.cpp ../../afl/afl_driver.cpp)
+if(NOT MSVC)
+  # AFL is not supported on Windows.
----------------
kcc wrote:
> at the very least the comment is confusing. 
> If though AFL is not supported on windows, why should we disable this test? It does not actually use afl... 
@kcc Yes, you are right. I disabled it because afl_driver was not ported yet. I will abandon this review, since I have updated afl_driver to work on Windows.


Repository:
  rL LLVM

https://reviews.llvm.org/D27871





More information about the llvm-commits mailing list