[PATCH] D27912: [XRay] [compiler-rt] Include argv[0] in the log file name.

[Dean Michael Berris via Phabricator via llvm-commits]

dberris requested changes to this revision.
dberris added a comment.
This revision now requires changes to proceed.

I was thinking it might be better if you made a specific test just for this -- that the "default" (i.e. not setting the pattern with the XRAY_OPTIONS environment variable) would be better, so that we can isolate the feature in a specific test.



================
Comment at: test/xray/TestCases/Linux/fixedsize-logging.cc:5
 // RUN: XRAY_OPTIONS="verbosity=1 xray_logfile_base=fixedsize-logging-" %run %t 2>&1 | FileCheck %s
+// RUN: ls -la fixedsize-logging-$(basename %t).?????? 2>&1
 //
----------------
I'm not sure we can rely on shell expansion to work here. Can you think of a different way of doing this, where you look for the filename on the "default" (i.e. non-configured explicitly) name here?


https://reviews.llvm.org/D27912