[PATCH] D27711: ELF/AArch64: Fix dynamic relocation against local symbol in shared objects

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 18 17:56:16 PST 2016


Adhemerval Zanella via Phabricator <reviews at reviews.llvm.org> writes:
> @@ -154,8 +154,8 @@
>        Config->Shared) {
>      if (In<ELFT>::Got->addDynTlsEntry(Body)) {
>        uintX_t Off = In<ELFT>::Got->getGlobalDynOffset(Body);
> -      In<ELFT>::RelaDyn->addReloc(
> -          {Target->TlsDescRel, In<ELFT>::Got, Off, false, &Body, 0});
> +      In<ELFT>::RelaDyn->addReloc({Target->TlsDescRel, In<ELFT>::Got, Off,
> +                                   !Body.isPreemptible(), &Body, 0});

Please use the existing variable. LGTM with that.

Cheers,
Rafael


More information about the llvm-commits mailing list