[PATCH] D27751: [LLVM] Use after move bug fixes
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 17 16:07:31 PST 2016
vsk added inline comments.
================
Comment at: tools/llvm-profdata/llvm-profdata.cpp:53
if (E.isA<InstrProfError>()) {
handleAllErrors(std::move(E), [&](const InstrProfError &IPE) {
instrprof_error instrError = IPE.get();
----------------
mehdi_amini wrote:
> I'm wondering why there is a check for error before calling handleAllErrors here? (@lhames while you're at it...)
If it is an instrprof error, we'd like the chance to inspect it and display an additional hint, instead of simply printing out a string representation of the error.
https://reviews.llvm.org/D27751
More information about the llvm-commits
mailing list