[PATCH] D27870: [libFuzzer] Diff 25 - Fix test with shared libraries on Windows.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 16:27:25 PST 2016


zturner added a comment.

If



================
Comment at: lib/Fuzzer/test/CMakeLists.txt:218
   "${CMAKE_BINARY_DIR}/lib/Fuzzer/test")
-set_target_properties(LLVMFuzzer-DSO1 PROPERTIES LIBRARY_OUTPUT_DIRECTORY
-  "${CMAKE_BINARY_DIR}/lib/Fuzzer/lib")
-set_target_properties(LLVMFuzzer-DSO2 PROPERTIES LIBRARY_OUTPUT_DIRECTORY
-  "${CMAKE_BINARY_DIR}/lib/Fuzzer/lib")
+if(MSVC)
+  # Import libraries will be created in the bin directory.
----------------
kcc wrote:
> That's bad. Please try to find a way to avoid this. 
I'm not sure I follow the logic here.  Without this patch, where do the .lib and .dll file end up, and is the problem occuring during link time or runtime?


Repository:
  rL LLVM

https://reviews.llvm.org/D27870





More information about the llvm-commits mailing list