[PATCH] D27868: [libFuzzer] Diff 23 - Properly use compiler options supported on Windows.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: lib/Fuzzer/test/CMakeLists.txt:30
+  # Only include coverage options supported for Windows.
+  set(CMAKE_CXX_FLAGS "${LIBFUZZER_FLAGS_BASE} -fsanitize-coverage=edge")
+else()
----------------
Nope. =edge should not be used any more with libFuzzer. 
I am going to delete the libFuzzer code that supports it pretty soon. 

What's wrong with trace-pc-guard,trace-cmp on windows? 


================
Comment at: lib/Fuzzer/test/CMakeLists.txt:37
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g")
+else()
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Zi")
----------------
hmmm. What is the 'else' compiler? 


Repository:
  rL LLVM

https://reviews.llvm.org/D27868