[PATCH] D27716: [ELF] - Implemented --retain-symbols-file option

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Writer.cpp:427
+  if (Config->Discard == DiscardPolicy::RetainFile)
+    if (!Config->RetainSymbolsFile.count(CachedHashString(B.getName())))
+      return false;
----------------
ruiu wrote:
> Does this compile? You are still using CachedHashString.
Unusual, but it was. I think because of 

```
operator StringRef() const { return val(); }
```

I'll fix.


https://reviews.llvm.org/D27716