[PATCH] D27716: [ELF] - Implemented --retain-symbols-file option

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Driver.cpp:480-483
+  std::transform(Arr.begin(), Arr.end(), Arr.begin(),
+                 [](StringRef S) { return S.trim(); });
+  Arr.erase(std::remove_if(Arr.begin(), Arr.end(),
+                           [](StringRef S) { return S.empty(); }),
----------------
ruiu wrote:
> I think plain, boring, non-higher-order code is easier to read.
> 
>   for (StringRef S : Arr) {
>     S = S.trim();
>     if (!S.empty())
>       Res.push_back(S);
>   }
Looks so..


https://reviews.llvm.org/D27716