[PATCH] D27838: Extract a TBAAVerifier out of the verifier (NFC)

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:4472
+  if (Diagnostic)                                                              \
+    Diagnostic->CheckFailed(__VA_ARGS__);
+
----------------
sanjoy wrote:
> I assume you'll add a `this->HasFailed = true` type thing here later?
> 
> Also, I'd mildly prefer using `this->Diagnostic` instead of `Diagnostic`, since this is in a macro.
> 
> Actually, why is this a macro at all?  Can't it be a normal templated function just like `VerifierSupport::CheckFailed`?
> I assume you'll add a this->HasFailed = true type thing here later?

Not in my plan? I expect to always return false (from the `AssertTBAA` macro on invalid). I sent you D27839 so you can see how it is used in the Reader.

> Actually, why is this a macro at all? Can't it be a normal templated function just like VerifierSupport::CheckFailed?

Good point! Done.





https://reviews.llvm.org/D27838