[PATCH] D27324: IPO: Introduce ThinLTOBitcodeWriter pass.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:201
+  std::string ModuleId = getModuleId(&M);
+  if (ModuleId.empty()) {
+    // We couldn't generate a module ID for this module, just write it out as a
----------------
pcc wrote:
> mehdi_amini wrote:
> > This seems dead code to me, the returned value is ` return ("$" + Str).str();` which can't be empty.
> See line 63, also the test case unsplittable.ll.
Oh right!


https://reviews.llvm.org/D27324