tejohnson added a comment. The change looks ok to me, but I'm concerned about having the caching broken with ThinLTO + sample PGO. At least let's get that part reviewed, so these patches can go in back to back. https://reviews.llvm.org/D27790