[PATCH] D27392: Vectorcall Calling Convention - Adding CodeGen Complete Support

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good. Please fix the remaining style issues before committing. Thanks for the patch!



================
Comment at: include/llvm/CodeGen/CallingConvLower.h:543
+  template<class T>
+  void AnalyzeArgumentsSecondPass(const SmallVectorImpl<T>& Args, CCAssignFn Fn) {
+    unsigned NumFirstPassLocs = Locs.size();
----------------
Thanks! I think this looks a lot better factored here.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:2755
 
+static bool is_sorted(const SmallVectorImpl<CCValAssign>& ArgLocs) {
+  return std::is_sorted(ArgLocs.begin(), ArgLocs.end(), 
----------------
This should have a more descriptive name in LLVM style. isSortedByValNo or something?


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:2811
+  assert(is_sorted(ArgLocs) && 
+    "Argument Location list must be sorted before lowering");
 
----------------
formatting


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:3322
+  assert(is_sorted(ArgLocs) &&
+    "Argument Location list must be sorted before lowering");
+
----------------
formatting


Repository:
  rL LLVM

https://reviews.llvm.org/D27392