[PATCH] D27770: [ELF][MIPS] Allow .MIPS.abiflags larger than one Elf_Mips_ABIFlags struct

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: test/ELF/mips-merge-abiflags.s:6
+# RUN: llvm-readobj -file-headers -sections -mips-abi-flags \
+# RUN:   %p/Inputs/mips-concatenated-abiflags.so | FileCheck \
+# RUN:   --check-prefix=CONCAT %s
----------------
atanasyan wrote:
>   # I guess you want to check %t.exe (file produced by LLD) not mips-concatenated-abiflags.so here.
>   # It is enough to use the `-mips-abi-flags` flag only and do not check ELF header and sections list.
>   # Does LLD really show the "invalid size of .MIPS.abiflags section" error message if concatenated .MIPS.abiflags sections are in a DSO (not a regular object file)?
1. I wanted to check that the .so  file generates  "The .MIPS.abiflags section has a wrong size." and that .MIPS.abiflags size is 48. I guess I can remove the other checks like testing the ELF header
2. I also wanted to test the size of the .MIPS.abiflags, but I guess I can remove testing the header
3. Seems you are right it only happens with .o files that have multiple abiflags structs. Will update the test case. Should I remove the .so file? or also test that linking against such a file works?


https://reviews.llvm.org/D27770