[PATCH] D27679: Simplify format member detection in FormatVariadic

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 09:57:17 PST 2016


labath updated this revision to Diff 81405.
labath added a comment.

Yes, I can. I can also add a static_assert test for that.

As for the std::move issue, the only two options (which do not involve massive
template magic) I can think of are:

- live with it
- have the base class not store the formatted member and leave it up for each derived class to decide how to store it.


https://reviews.llvm.org/D27679

Files:
  docs/ProgrammersManual.rst
  include/llvm/Support/FormatAdapters.h
  include/llvm/Support/FormatCommon.h
  include/llvm/Support/FormatProviders.h
  include/llvm/Support/FormatVariadic.h
  include/llvm/Support/FormatVariadicDetails.h
  unittests/Support/FormatVariadicTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27679.81405.patch
Type: text/x-patch
Size: 18469 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161214/fe4fdd9c/attachment.bin>


More information about the llvm-commits mailing list