[PATCH] D27679: Simplify format member detection in FormatVariadic

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 08:57:51 PST 2016


labath updated this revision to Diff 81395.
labath updated the summary for this revision.
labath added a comment.

Running the unittests for the latest version discovered a new issue. The usage
of && in the FormatAdapter base class forces each class deriving from it to use
std::move. I am not sure how much we care about that, but I am going to look
more into how we can avoid that.


https://reviews.llvm.org/D27679

Files:
  docs/ProgrammersManual.rst
  include/llvm/Support/FormatAdapters.h
  include/llvm/Support/FormatCommon.h
  include/llvm/Support/FormatProviders.h
  include/llvm/Support/FormatVariadic.h
  include/llvm/Support/FormatVariadicDetails.h
  unittests/Support/FormatVariadicTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27679.81395.patch
Type: text/x-patch
Size: 18265 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161214/f7d8dcb4/attachment.bin>


More information about the llvm-commits mailing list