[PATCH] D27751: Use after move bug fixes

Malcolm Parsons via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 05:18:39 PST 2016


malcolm.parsons added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugAbbrev.cpp:42
     PrevAbbrCode = AbbrDecl.getCode();
-    Decls.push_back(std::move(AbbrDecl));
+    Decls.push_back(AbbrDecl);
   }
----------------
False positive - extract() reinitializes.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugAbbrev.cpp:85
       break;
-    AbbrDeclSets[CUAbbrOffset] = std::move(AbbrDecls);
+    AbbrDeclSets[CUAbbrOffset] = AbbrDecls;
   }
----------------
False positive - extract() reinitializes.


https://reviews.llvm.org/D27751





More information about the llvm-commits mailing list