[PATCH] D27745: [llvm] Turn off reverse iteration of SmallPtrSet by default

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang created this revision.
mgrang added a reviewer: qcolombet.
mgrang added a subscriber: llvm-commits.
mgrang set the repository for this revision to rL LLVM.

Turn off reverse iteration of SmallPtrSet by default since it causes
 builtbots to crash. Will re-enable it once I have a fix.


Repository:
  rL LLVM

https://reviews.llvm.org/D27745

Files:
  include/llvm/ADT/SmallPtrSet.h
  lib/Support/CommandLine.cpp


Index: lib/Support/CommandLine.cpp
===================================================================
--- lib/Support/CommandLine.cpp
+++ lib/Support/CommandLine.cpp
@@ -52,7 +52,7 @@
 // This will help uncover differences in codegen caused due to undefined
 // iteration order.
 static cl::opt<bool, true> ReverseIteration("reverse-iterate",
-  cl::location(ReverseIterate<bool>::value), cl::init(true));
+  cl::location(ReverseIterate<bool>::value), cl::init(false));
 }
 #endif
 
Index: include/llvm/ADT/SmallPtrSet.h
===================================================================
--- include/llvm/ADT/SmallPtrSet.h
+++ include/llvm/ADT/SmallPtrSet.h
@@ -29,7 +29,7 @@
 #if LLVM_ENABLE_ABI_BREAKING_CHECKS
 namespace llvm {
 template <class T = void> struct ReverseIterate { static bool value; };
-template <class T> bool ReverseIterate<T>::value = true;
+template <class T> bool ReverseIterate<T>::value = false;
 }
 #endif
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27745.81337.patch
Type: text/x-patch
Size: 936 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161214/caccf3c0/attachment.bin>