[PATCH] D27721: Add a c_str() member to StringLiteral

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 16:13:33 PST 2016


ruiu added a comment.

We instantiate a StringRefZ for each string in a string table, but most of them are not going to be used because not all symbols are used for symbol resolution. So, most strlen() are going to be just waste of CPU time. However, still, StringRefZ is useful because it is a uniform representation of a string there. If StringRef computes string size lazily if it doesn't know it at compile time, we can just use StringRef there.


https://reviews.llvm.org/D27721





More information about the llvm-commits mailing list