[PATCH] D27737: Switch functions that returned bool and filled in a DWARFFormValue arg with ones that return Optional<DWARFFormValue>
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 13 15:29:52 PST 2016
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
LGTM (small comments inline).
================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAbbreviationDeclaration.h:82
/// \param FormValue the form value that will be filled in.
/// \returns true if the attribute was extracted into \p FormValue.
+ Optional<DWARFFormValue> getAttributeValue(const uint32_t DIEOffset,
----------------
Could you also update the comment please?
================
Comment at: lib/DebugInfo/DWARF/DWARFDie.cpp:138
+DWARFDie::getAttributeValue(dwarf::Attribute Attr) const {
+ if (!isValid())
+ return None;
----------------
This looks reasonable, but should probably be a separate NFC commit.
https://reviews.llvm.org/D27737
More information about the llvm-commits
mailing list