[PATCH] D27078: LTO: Port the legacy LTO API to ModuleSymbolTable.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 11:58:54 PST 2016


pcc added inline comments.


================
Comment at: llvm/lib/LTO/LTOModule.cpp:238
 
-  std::unique_ptr<object::IRObjectFile> IRObj(
-      new object::IRObjectFile(Buffer, std::move(M)));
-
-  std::unique_ptr<LTOModule> Ret(new LTOModule(std::move(IRObj), target));
+  std::unique_ptr<LTOModule> Ret(new LTOModule(std::move(M), Buffer, target));
   Ret->parseSymbols();
----------------
mehdi_amini wrote:
> `make_unique`?
That won't work, LTOModule's ctor is private.


https://reviews.llvm.org/D27078





More information about the llvm-commits mailing list