[PATCH] D27688: [framelowering] Skip dbg values when getting next/previous instruction.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 15:41:16 PST 2016


fhahn added inline comments.


================
Comment at: lib/Target/X86/X86FrameLowering.cpp:376
+  while (PI != MBB.begin() && PI->isDebugValue())
+    --PI;
+
----------------
aprantl wrote:
> Would it make sense to introduce a better API for this? Skipping over all DBG_VALUEs is a pretty common operation.
I think a better API for this would make sense. I'll have a look tomorrow and see there's an existing API for that or if a new API could be introduced.


https://reviews.llvm.org/D27688





More information about the llvm-commits mailing list