[PATCH] D27415: [ELF] - Replace MergeOutputSection with synthetic input section MergeSection.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 15:34:00 PST 2016


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
> I think that my point is, if a section is written to output, it should
> be marked as "live" whatever its type is.

Agreed.

> If non-alloc sections are copied to output unconditionally, they should be marked as "live" by default from the beginning.

I thought we did just that.

> Doing something "non-live sections are sometimes actually live under some condition, so handle that special case here" is not a good idea.

The only complication we have that is unfortunately necessary given how
current debug info is implemented is that a non-alloc (and therefore
live) section can have a relocation pointing to a dead alloc section.

Cheers,
Rafael


More information about the llvm-commits mailing list