[PATCH] D27668: Remove IsMetadataMaterialized from BitcodeReader (NFC)

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 11:34:06 PST 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL289457: Remove IsMetadataMaterialized from BitcodeReader (NFC) (authored by mehdi_amini).

Changed prior to commit:
  https://reviews.llvm.org/D27668?vs=81043&id=81116#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D27668

Files:
  llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp


Index: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
===================================================================
--- llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
+++ llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
@@ -595,9 +595,6 @@
   /// (e.g.) blockaddress forward references.
   bool WillMaterializeAllForwardRefs = false;
 
-  /// True if any Metadata block has been materialized.
-  bool IsMetadataMaterialized = false;
-
   bool StripDebugInfo = false;
 
   /// Functions that need to be matched with subprograms when upgrading old
@@ -2410,7 +2407,6 @@
   assert((ModuleLevel || DeferredMetadataInfo.empty()) &&
          "Must read all module-level metadata before function-level");
 
-  IsMetadataMaterialized = true;
   unsigned NextMetadataNo = MetadataList.size();
 
   if (!ModuleLevel && MetadataList.hasFwdRefs())
@@ -3959,7 +3955,7 @@
           return Err;
         break;
       case bitc::METADATA_BLOCK_ID:
-        if (ShouldLazyLoadMetadata && !IsMetadataMaterialized) {
+        if (ShouldLazyLoadMetadata) {
           if (Error Err = rememberAndSkipMetadata())
             return Err;
           break;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27668.81116.patch
Type: text/x-patch
Size: 1144 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161212/5facac68/attachment.bin>


More information about the llvm-commits mailing list