[llvm] r289457 - Remove IsMetadataMaterialized from BitcodeReader (NFC)

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 11:23:39 PST 2016


Author: mehdi_amini
Date: Mon Dec 12 13:23:39 2016
New Revision: 289457

URL: http://llvm.org/viewvc/llvm-project?rev=289457&view=rev
Log:
Remove IsMetadataMaterialized from BitcodeReader (NFC)

Summary: It does not seem useful.

Reviewers: pcc, dexonsmith

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D27668

Modified:
    llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp

Modified: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp?rev=289457&r1=289456&r2=289457&view=diff
==============================================================================
--- llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp (original)
+++ llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp Mon Dec 12 13:23:39 2016
@@ -595,9 +595,6 @@ class BitcodeReader : public BitcodeRead
   /// (e.g.) blockaddress forward references.
   bool WillMaterializeAllForwardRefs = false;
 
-  /// True if any Metadata block has been materialized.
-  bool IsMetadataMaterialized = false;
-
   bool StripDebugInfo = false;
 
   /// Functions that need to be matched with subprograms when upgrading old
@@ -2410,7 +2407,6 @@ Error BitcodeReader::parseMetadata(bool
   assert((ModuleLevel || DeferredMetadataInfo.empty()) &&
          "Must read all module-level metadata before function-level");
 
-  IsMetadataMaterialized = true;
   unsigned NextMetadataNo = MetadataList.size();
 
   if (!ModuleLevel && MetadataList.hasFwdRefs())
@@ -3959,7 +3955,7 @@ Error BitcodeReader::parseModule(uint64_
           return Err;
         break;
       case bitc::METADATA_BLOCK_ID:
-        if (ShouldLazyLoadMetadata && !IsMetadataMaterialized) {
+        if (ShouldLazyLoadMetadata) {
           if (Error Err = rememberAndSkipMetadata())
             return Err;
           break;




More information about the llvm-commits mailing list