[PATCH] D27659: [sanitizer] intercept bstring functions

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 10:54:23 PST 2016


kcc added a comment.

please add tests adjacent and similar to test/asan/TestCases/Linux/memmem_test.cc



================
Comment at: lib/sanitizer_common/sanitizer_platform_interceptors.h:277
 #define SANITIZER_INTERCEPT___BZERO SI_MAC
+#define SANITIZER_INTERCEPT_BZERO 1
+#define SANITIZER_INTERCEPT_BCOPY 1
----------------
I think these need to be SI_LINUX, not 1. 
If we try to intercept a function that does not exist on other OSes things will fail there. 



https://reviews.llvm.org/D27659





More information about the llvm-commits mailing list