[PATCH] D27467: [mips][rtdyld] Move MIPS relocation resolution to a subclass and implement N32 relocations

[Simon Dardis via Phabricator via llvm-commits]

sdardis added inline comments.


================
Comment at: lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h:88
 
+protected:
   size_t getGOTEntrySize();
----------------
atanasyan wrote:
> Are this and similar changes below mandatory for this patch? Maybe move them into separate commit?
This and the changes below expose the minimum number of class members for use in a subclass of RuntimeDyldELF which this patch implements.


================
Comment at: lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldELFMips.h:20
+
+class RuntimeDyldELFMips : public RuntimeDyldELF {
+public:
----------------
atanasyan wrote:
> Is it really necessary to move MIPS specific methods into the separate class? What is intention?
The intention here in creating a separate class to handle MIPS relocations is to simplify resolving N32 relocations in a later patch. Factoring out some of the MIPS specific methods is similar to how other architecture+exe format combinations handle differences.


https://reviews.llvm.org/D27467