[PATCH] D26749: Generate aeabi_cdcmple libcalls

[Renato Golin via Phabricator via llvm-commits]

rengolin requested changes to this revision.
rengolin added a comment.
This revision now requires changes to proceed.

This is totally in the wrong place. Not only it's a hack on another combine, it's too late into the process.

For similar ABI handling, we have the constructor in ISelLowering to choose the right lib call. Look at divmod for the "correct way" (tm) to massage arguments.

It may not be pretty, but it also doesn't have the two critical problems this approach has:

1. We select functions and library calls, only to re-select them later.
2. It selectively passes on another combine, meaning there's no guarantee that all cases will be dealt with and validated.

I believe this works by luck and not design. That's why the more ugly library handling before DAGISel is executed is the only way.

cheers,
--renato


https://reviews.llvm.org/D26749