[PATCH] D27660: COFF: Load inputs immediately instead of adding them to a queue.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 11 14:00:40 PST 2016
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lld/COFF/SymbolTable.cpp:36-37
+ if (Config->Machine == IMAGE_FILE_MACHINE_UNKNOWN) {
+ if (MT != IMAGE_FILE_MACHINE_UNKNOWN)
+ Config->Machine = MT;
+ } else if (MT != IMAGE_FILE_MACHINE_UNKNOWN && Config->Machine != MT) {
----------------
You can assign to MT unconditionally.
================
Comment at: lld/COFF/SymbolTable.h:24
#include <future>
#include <list>
----------------
I believe you can remove this include.
https://reviews.llvm.org/D27660
More information about the llvm-commits
mailing list