[PATCH] D24941: [libc++][tests] Fixing some issues in unordered container tests

[Eric Fiselier via Phabricator via llvm-commits]

EricWF added a comment.

This almost LGTM. I would like to see the remaining `_db` tests moved into the `test/libcxx` subdirectory and I would like to see them manually define `_LIBCPP_DEBUG` instead of guarding for when it is not defined.

Note this should only be done for tests that are entirely debug tests and which test no non-debug behavior.



================
Comment at: test/std/containers/sequences/vector/vector.modifiers/erase_iter_db2.pass.cpp:16
+
 #if _LIBCPP_DEBUG >= 1
 
----------------
For tests like this, where the entire test is a debug test (guarded by `#if _LIBCPP_DEBUG >= N`) please do two things:

1) Move the test from `test/std/.../foo/...` to `test/libcxx/.../foo/...`.
2) Manually define `_LIBCPP_DEBUG` instead of checking for it. This way the debug test always run.


Repository:
  rL LLVM

https://reviews.llvm.org/D24941