[PATCH] D27152: Merge strings using sharded hash tables.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 10 14:30:46 PST 2016


On Dec 10, 2016 2:12 PM, "Rafael Avila de Espindola" <
rafael.espindola at gmail.com> wrote:

Rui Ueyama via Phabricator via llvm-commits


> +  // If threading is disabled, use the default string table builder
> +  // because our concurrent one is not as fast as the single-threaded
> +  // one on single core.
> +  if (!Config->Threads || StringRef(getenv("LLD_TEST")) == "1") {
> +    Builder.reset(new StringTableBuilder(StringTableBuilder::RAW,
Alignment));
>      finalizeNoTailMerge();
> +    return;
> +  }
> +

This means we produce different results with threads disabled?


Yes. But as long as you pass the same command line arguments, results are
the same.

What is the LLD_TEST thing?


That's for debugging. Removed.


Cheers,
Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161210/ba20143e/attachment.html>


More information about the llvm-commits mailing list