[PATCH] D26817: [APFloat] Implement PPCDoubleDouble add and subtract.

[Eric Christopher via Phabricator via llvm-commits]

echristo added a reviewer: scanon.
echristo added a comment.

Couple of small inline nits. Willing to go with it on the implementation details.

Adding Steve in case he wishes to comment.

-eric



================
Comment at: llvm/lib/Support/APFloat.cpp:4069
+  }
+  llvm_unreachable("");
+}
----------------
kbarton wrote:
> Why is this an empty string?
Still an empty string :)


================
Comment at: llvm/lib/Support/APFloat.cpp:4167
+}
+
 } // End llvm namespace
----------------
Since you're adding a Print you might want to add a dump as well. (And while I realize it's against how the class currently works Print->print please).


https://reviews.llvm.org/D26817