[PATCH] D27197: [PM] Support invalidation of inner analysis managers from a pass over the outer IR unit.
Justin Lebar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 9 19:29:35 PST 2016
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
I am happy.
================
Comment at: unittests/Analysis/CGSCCPassManagerTest.cpp:645
+ " ret void\n"
+ "}\n");
+ {
----------------
chandlerc wrote:
> jlebar wrote:
> > Raw string?
> Would it be an improvement? I'm not sure...
>
> Anyways, should be a separate patch and applied to all the textual modules here if we can rely on this feature and it is worth using.
Personally I think it would be, if for no other reason than it's a lot easier to edit text inside of raw strings. (Also it's visually less noisy to read.)
But I'm fine doing that separately.
https://reviews.llvm.org/D27197
More information about the llvm-commits
mailing list