[PATCH] D27635: [ThinLTO] Import only necessary DICompileUnit fields

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: test/ThinLTO/X86/debuginfo-cu-import.ll:14
+; CHECK-NOT: DICompileUnit{{.*}} retainedTypes:
+; CHECK-NOT: DICompileUnit{{.*}} globals:
+; CHECK: DICompileUnit{{.*}} imports: ![[IMP:[0-9]+]]
----------------
mehdi_amini wrote:
> aprantl wrote:
> > mehdi_amini wrote:
> > > aprantl wrote:
> > > > I'm not sure this does what we want to. How many DICompileUnits do we expect in the final output? If there is more than one, this will only check the first one.
> > > It will check that there is no DICompileUnit with any of this field before having a DICompileUnit with an imports field (and we should have only one with imports, and this is the one we don't want the above fields on).
> > > 
> > > Maybe we could get rid of the debug info in the destination module? That should remove any ambiguity.
> > Ok, I wasn't aware of the imports: detail. One way to make the intention clear and unambigous would be to add a CHECK-NOT: DICompileUnit after the CHECK for the CU with the imports.
> That wouldn't be correct, right now we allow the other DICompileUnit to appear later.
But then this takes us back to my very first comment — that the CHECK-NOTs will only check that we handled the CUs correctly that happen to appear before the CU with the imports?


https://reviews.llvm.org/D27635