[PATCH] D26506: Compiler-rt part of D26230: Add (constant) masked load/store support

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubabrecka added a comment.

In https://reviews.llvm.org/D26506#618226, @filcab wrote:

> In https://reviews.llvm.org/D26506#612095, @kubabrecka wrote:
>
> > Can we just add "REQUIRES: avx" to the test and lit?
>
>
> No. That feature is not detected at all and there's no cmake scaffolding to expose it.
>  I think this test is too specific, and piggybacking on things that are tested (we're testing the instrumentation itself in llvm-land, callbacks, etc, are the exact same as regular instrumentation).
>  Since this is a matter of instrument (the exact same way as regular loads/stores) vs. no instrument, I think it's not useful to add all the scaffolding for this test.
>  If the handling in compiler-rt were in some way different from regular loads/stores, then I think we should add it. But as it is, I'm not sure it's worth the effort.


I was thinking about running grep /proc/cpuinfo (and systl hw on Darwin) in lit.cfg to detect AVX.  Anyway, I'm fine with dropping this test (and just having the instrumentation test).


Repository:
  rL LLVM

https://reviews.llvm.org/D26506