[PATCH] D26283: [ELF] - Partial support of --gdb-index command line option (Part 3).

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 10:27:05 PST 2016


dblaikie added inline comments.


================
Comment at: ELF/GdbIndex.cpp:118
+      }
+    }
+  }
----------------
clayborg wrote:
> I'll let others comment on what is right to do as I am just starting out reviewing things in LLVM and don't know all the ropes. David?
Yeah, we go back and forth on stuff like this - in this case I think the code is short (granted, that also means the work to do it ahead of time isn't that big either) & George has been pretty responsive/quick on feedback/changes like this, so I'm OK with it going in after this patch.


https://reviews.llvm.org/D26283





More information about the llvm-commits mailing list