[PATCH] D27603: Propagate -fdiagnostics-color to LLD.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lib/Driver/Tools.cpp:283
+  // Add an extra parameter for LLD. If the linker is LLD, we want to
+  // propagate -fdiagnostics-color.
+  if (StringRef(TC.GetLinkerPath()).endswith("ld.lld") &&
----------------
nit: Clang's original spelling was -fcolor-diagnostics, which reads better in English. GCC made -fdiagnostics-color, which we added as an alias. It makes sense ontologically, but it doesn't read as well in a comment.


https://reviews.llvm.org/D27603