[PATCH] D26149: [DAGCombiner] Match load by bytes idiom and fold it into a single load

[Artur Pilipenko via Phabricator via llvm-commits]

apilipenko added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4401
+  case ISD::OR: {
+    auto &LHS = collectByteProviders(Op->getOperand(0),
+                                     /*CheckNumberOfUses=*/true);
----------------
filcab wrote:
> Aren't you binding to the object returned in `collectByteProviders`? Can you run a test case that triggers this optimization under asan with `ASAN_OPTIONS=detect_stack_use_after_return=true`?
collectByteProviders return the result by value, so it's not a problem. The reference here is misleading and should be just auto. Fixed here and there.


https://reviews.llvm.org/D26149