[PATCH] D27283: Fix invalid addrspacecast due to combining alloca with global var

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 9 07:42:06 PST 2016


yaxunl marked 2 inline comments as done.
yaxunl added a comment.

In https://reviews.llvm.org/D27283#617931, @majnemer wrote:

> There are two different things going on in this patch: a correctness fix and an optimization.  How about we split out the correctness fix out to another patch?


The correctness-only fix will generate less optimal code which cause a regression in another lit test.

I have a fix for the issue you mentioned above.


https://reviews.llvm.org/D27283





More information about the llvm-commits mailing list