[PATCH] D27392: Vectorcall Calling Convention - Adding CodeGen Complete Support

[Amjad Aboud via Phabricator via llvm-commits]

aaboud added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7747
+      }
       if (Args[i].isInReg)
         Flags.setInReg();
----------------
you already checked this case.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:2807
+
+  // Sort the the locations of the arguments according to their original
+  // position
----------------
You have a typo: "the the".
Also, can you explain why you are sorting the ArgLoc even for non-VectorCall calling convention?
Is that needed?


================
Comment at: test/CodeGen/X86/vectorcall.ll:71
-; tablegen any other way.
-define x86_vectorcallcc {double, double, double, double, double} @test_fp_4() {
-  ret {double, double, double, double, double}
----------------
Do you really want to remove this test? Cannot you just fix it?


Repository:
  rL LLVM

https://reviews.llvm.org/D27392